Update test devices#1850
Conversation
The Galaxy Tab S3 is no longer avalible and while I am here I might as well up android latest to more current devices
AustinBenoit
added
skip-release-notes
github-actions
Bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @AustinBenoit on commit 5d1f3e3 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android test device matrix in scripts/gha/print_matrix_configuration.py to include newer device models and API levels. The review feedback highlights significant issues, including the use of an invalid API level (36), the inclusion of unreleased hardware (Pixel 10 and Galaxy S25 series) that is likely unavailable in Firebase Test Lab, and inconsistencies in API versions within the defined device groups.
| {"type": "ftl", "device": "model=tokay,version=36"}, # Pixel 9 | ||
| {"type": "ftl", "device": "model=frankel,version=36"}, # Pixel 10 | ||
| {"type": "ftl", "device": "model=stallion,version=36"}, # Pixel 10a | ||
| {"type": "ftl", "device": "model=mustang,version=36"}, # Pixel 10 Pro XL | ||
| {"type": "ftl", "device": "model=rango,version=36"}, # Pixel 10 Pro Fold |
There was a problem hiding this comment.
The android_latest configuration contains several discrepancies:
- API Version Inconsistency: There is a mix of API level 36 and API level 34 (and 33 for the Pixel Tablet) within the same group.
- Invalid API Level: API level 36 is not currently a standard Android release (Android 15 is API 35).
- Unreleased Hardware: Models such as
frankel(Pixel 10) andrango(Pixel 10 Pro Fold) refer to unreleased devices that are likely not yet available in Firebase Test Lab.
It is recommended to use a consistent, supported API level (e.g., 34 or 35) and valid device models to ensure the stability of the integration tests.
| {"type": "ftl", "device": "model=b0q,version=33"}, # Galaxy S22 Ultra | ||
| {"type": "ftl", "device": "model=b4q,version=33"}, # Galaxy Z Flip4 | ||
| {"type": "ftl", "device": "model=gts9wifi,version=34"}, # Galaxy Tab S9 | ||
| {"type": "ftl", "device": "model=pa3q,version=36"}, # Galaxy S25 Ultra |
There was a problem hiding this comment.
The model pa3q (Galaxy S25 Ultra) and the specified version=36 are inconsistent with other devices in this group (e.g., Galaxy Tab S9 and Z Flip6 use version 34). Additionally, this hardware and API level are likely not yet available in Firebase Test Lab. Please use a consistent and supported configuration.
| "android_target": [ | ||
| {"type": "ftl", "device": "model=blueline,version=28"}, # Pixel 3 | ||
| {"type": "ftl", "device": "model=gts3lltevzw,version=28"}, # Galaxy Tab S3 | ||
| {"type": "ftl", "device": "model=gts8wifi,version=34"}, # Galaxy Tab S8 |
There was a problem hiding this comment.
The android_target group appears to be intended for testing on API level 28 (Android 9), as seen with the other devices in this list (Pixel 3 and AQUOS sense2). Replacing the Galaxy Tab S3 with a Galaxy Tab S8 running API level 34 introduces an inconsistency in the API coverage for this group. If the goal is to maintain a consistent baseline for 'target' devices, consider using a device model that supports API level 28 in Firebase Test Lab.
There was a problem hiding this comment.
Well I still want a samsung and a table this is really the only option.
github-actions
Bot
added
the
tests: succeeded
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
github-actions
Bot
added
tests: in-progress
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
2 participants
Description
Update test devices
The Galaxy Tab S3 is no longer available and while I am here I might as well up android latest to more current devices
Testing
Will run integration tests to validate.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.